comment on

I just moved the repository from mobius (which is dying soon) to unlocalhost, so i changed your link above. Shortly after, i thought that i should finally get around to fixing the problem. :D

Here is the shortest workaround i could come up with:

# somewhere at top add this
use HTML::Entities;

# and somewhere in the middle add this
sub print_revision {
   my $self = shift;
   my @time_units = ('days', 'hours', 'minutes', 'seconds');
   my ($uri_base, $revision, $diff_revision) = @_;
   my $revision_uri = "$uri_base?r=" . $revision->number();
   my $date = localtime($revision->date());
   my $age = join(', ',
      map { $revision->age()->{$_} . ' ' . $_ } @time_units);
   my $symbol = $revision->symbol() || '&nbsp;';
   $self->request()->print("<tr>
      <td><a href=$revision_uri>" .
      $revision->number() . '</td>' .
      '<td>' . $revision->author() . '</td>' .
      '<td>' . $revision->state() . '</td>' .
      "<td>$symbol</td><td>$date</td><td>$age</td>" .
      '<td>' . encode_entities($revision->comment()) . '</td>');
   if ($diff_revision eq $revision->number()) {
      $self->request()->print('<td>selected for diff</td>');
   } else {
      if ($diff_revision) {
         $self->request()->print(qq|<td><a href="$uri_base?ds=| .
         $revision->number()  .
         qq|&dt=$diff_revision">select for diff | .
         "with $diff_revision</a>");
      } else {
         $self->request()->print(qq|<td><a href="$uri_base?ds=| .
         $revision->number()  .
         '">select for diff</a>');
      }
   }
   $self->request()->print('</tr>');
}
[download]

The magic line is:

'<td>' . encode_entities($revision->comment()) . '</td>');
[download]

ugly hack (having to repeat all of that code) .. but it works ;)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

In reply to (jeffa) 2Re: Apache::CVS::HTML + Perl::Tidy by jeffa
in thread Apache::CVS::HTML + Perl::Tidy by jeffa

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Clear questions and runnable code get the best and fastest answer
	PerlMonks