# Output an image to the browser
sub show_img {
my $img = shift;
my ($mime) = $img =~ /\.(gif|jpe?g|png)$/;
$mime = 'jpeg' if $mime eq 'jpg';
open my $fh, '<', $img or die "Could not open $img for read: $!";
binmode $fh;
my $img_data = do { local $/; <$fh> };
close $fh;
print header('image/' . $mime), $img_data;
exit;
}
Rather than pump the image yourself, I'd put the images somewhere in your www-server space (an unlinked unannounced directory), and then use an internal redirect:
print redirect("/some/webpath/to/selected/image.jpg");
The advantages are many:
- The server is better than you at pumping data.
- The values of last-modified and if-modified-since will be respected, allowing the server to avoid sending the data if the browser already has the image cached.
- You won't ever be able to accidentally access something outside the normal htdoc tree, even from bad programming or malicious hacking.
- Your CGI process goes away quicker.
- The code will be eight lines shorter. {grin}
-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|