From a code-review standpoint:
- There's far too much cut-n-paste-n-slightly-modified code in this program. Any time the same sequence of three or four lines of code appears amidst some other code that varies only slightly, it should be a big warning sign. For example, suppose you wanted to change "Processing..." to "Working...". You'd have to edit that in half a dozen places. Factor it out!
- Your chain of "if"-tests should be replaced by a simple hash pointing at the right subroutine to call.
That strategy would probably help in the rest as well.
-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|