comment on

You left out the mandatory "escape HTML entity" calls. Shame on you.

use HTML::Entities qw(encode_entities);
use URI::Find;
...
my $finder = URI::Find->new # instead of URI::Find::Schemeless
  ( 
    sub {
      my ($uri, $originalUri) = @_;
      return join "",
        q/<a href="/,
        encode_entities("$uri"),
        q/">/,
        encode_entities($originalUri),
        q/>/;
    }
  );

...
[download]

Yes, I've already complained to the author. He "fixed" the manpage incorrectly, by escaping the entire source text first. That breaks in-page URLs that look like http://example.com/foo/bar?a=b&c=d. {sigh} I was too worn out explaining to him why that was wrong to submit another fix.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

In reply to •Re: Change URIs in Text to HTML-Links by merlyn
in thread Change URIs in Text to HTML-Links by strat

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


P is for Practical
	PerlMonks