Beefy Boxes and Bandwidth Generously Provided by pair Networks
more useful options
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
I've just spent more than one hour debugging very wierd problem. Test script for one of my projects I'm currently working on died with error like:
Modification of a read-only value attempted at /usr/share/perl5/Net/DN +S/Resolver.pm line 235. Compilation failed in require at /usr/share/perl5/Net/DNS.pm line 23. BEGIN failed--compilation aborted at /usr/share/perl5/Net/DNS.pm line +23. Compilation failed in require at /usr/share/perl5/Mail/CheckUser.pm li +ne 28. BEGIN failed--compilation aborted at /usr/share/perl5/Mail/CheckUser.p +m line 30. .... ....
Let's look in Net/DNS/Resolver.pm:
.... sub res_init { if ($os eq "unix") { res_init_unix(); } .... } .... sub res_init_unix { read_config($resolv_conf) if (-f $resolv_conf) and (-r $resolv +_conf); .... } .... sub read_config { .... while (<FILE>) { <------ This is line 235 where it fails .... } .... res_init()
As you can see on load of Net::DNS::Resolver module it tries to read DNS resolver configuration file in subroutine read_config() if it runs on Unix and there exist this file. Nothing wrong with it at first look. Yet it fails with 'Modification of a read-only value attempted' error on while (<FILE>) { line.

Turned out that I had some code which could load Net::DNS module on demand and this code was called inside of map. My next step was finding that following snipplet dies with same error. map { require Net::DNS } 1; Than I removed all non-essential details and I got final test case: map { while(<>) { } } 1; Suddendly this error started to make sense to me. map associates $_ to elements of the passed list. In this case it is a list with a single element - constant 1. As it is a constant $_ becomes read-only but while(<>) { } still tries to assign data obtained from file handle to $_ and it results in this error.

So what is the conclusion? Do not use while(<>) { } unless you localize $_ or you are completly sure that nobody will call you code from map (or grep, or for/foreach - they are subject to the same problem). Personally I prefer always using while(my $line = <>) construct.

Update: These nodes demonstrate same problem with while(<>) { ... }: Method call to tied hash leads to file read error and opening a file destroys nulling entries in a list?!?!.

--
Ilya Martynov (http://martynov.org/)


In reply to while(<>) { ... } considered harmful by IlyaM

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others avoiding work at the Monastery: (6)
As of 2024-03-28 22:48 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found