See erikharrison's post. Just a quick comment from me: your code first tries a match and then a substitution which has to find the same match again. It is ok to try substitution on strings where the match would fail - the result will simply be no change. You can just remove the if:
while (<$FRAME_FILE>) {
s/$change_on/$change_off/g;
}
or simpler
s/$change_on/$change_off/g while <$FRAME_FILE>;
In fact, you can use substitutions in conditions as well:
if(s/$change_on/$change_off/) {
...
}
The block will only execute if a substitution happened.
Makeshifts last the longest.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|