Nice work. Lets add a bit of holistic consideration. What exactly is he trying to achieve? well, very simply it's a plural translation within english. In those instances where more than one system is down, he wishes to maintain a correct english sentence.
We thus minimise our code duplication like this (perl):
open(MAIL,"|mailx blah") || die "No mail stuff: $! \n";
if ($ct>0) {
print MAIL "\n$ct ".($ct>1 ? "are not available" : "is down")." at
+ this time.\n";
}
close(MAIL);
But of course the greatest optimisation is always achieved by considering the whole problem, not just the perl:
open(MAIL,"|mailx blah") || die "No mail stuff: $! \n";
print MAIL "\nSystems unavailable at this time: $ct\n" if ($ct>0)
close(MAIL);
Silly I know, but to the point: Good optimisation looks at the whole problem.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|