comment on

First off consider what the if statement is doing:

open(FIL,">>$myfil") || die "No open for ct tot: $! \n";
if($ct == 1){
        print FIL "\n$ct is down at this time.\n";
}
elsif($ct >= 2){
        print FIL "\n$ct are not available at this time.\n";
}
system("mailx -s 'Mail header' myemail < $myfil");
close(FIL);
[download]

Secondly consider using a pipe instead of writing to a file:

open(MAIL,"|mailx blah) || die "No mail stuff: $! \n";
if($ct == 1){
        print MAIL "\n$ct is down at this time.\n";
}
elsif($ct >= 2){
        print MAIL "\n$ct are not available at this time.\n";
}
close(MAIL);
[download]

Try some common Perl tricks:

# Removed brackets, replaced || with or due to higher presedence and r
+eadability 
# used single quotes on uninterpolated strings.
open MAIL,'|mailx blah' or die "No mail stuff: $!\n";

# Stuck the if statements at the end so it's more natural.
print MAIL "\n$ct is down at this time.\n" if $ct == 1;
print MAIL "\n$ct are not available at this time.\n" if $ct >= 2;

close(MAIL);
[download]

What? more elegant?.....um, it's arguable.

open(MAIL,"|mailx blah) || die "No mail stuff: $! \n";
SWITCH: {
   $ct >= 2   && { print MAIL "\n$ct are not available at this time.\n
+"; last SWITCH };
   $ct == 1   && { print MAIL "\n$ct is down at this time.\n"; last SW
+ITCH };
}
close(MAIL);
[download]

--

Brother Frankus.

In reply to Re: Can I clean this up?? by frankus
in thread Can I clean this up?? by Anonymous Monk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


laziness, impatience, and hubris
	PerlMonks