comment on

I would like to know if I could clean this up and get rid of my repititious lines such as the system(mail...) commands and anyother way to compact this?? I also tried playing with my open FIL and close FIL but could only get them to work as I have it below:

My script checks how many systems are down so the $ct variable represents how many systems are down.
Here is the part I was hoping I could condense:

if($ct == 1)
{
        print FIL "\n$ct is down at this time.\n";
        open(FIL,">>$myfil") || die "No open for ct tot: $! \n";
        system("mailx -s 'Mail header' myemail < $myfil");
        close(FIL);
}
elsif($ct >= 2)
{
        print FIL "\n$ct are not available at this time.\n";
        open(FIL,">>$myfil") || die "No open for ct tot: $! \n";
        system("mailx -s 'Mail header' myemail < $myfil");
        close(FIL);
}
close(FIL);
[download]

In reply to Can I clean this up?? by Anonymous Monk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


We don't bite newbies here... much
	PerlMonks