if ($homeurl !~ m[^http://|https://]) {
Careful. Your regex tests for http:// at the start of the string, or https:// anywhere in the string. The |-alternative is greedy if not enclosed in brackets. Also, it is better to keep or distinctions like this outside the regex engine.
In reply to the original question, I would suggest that it's semantically much better to write this as:
unless ($homeurl =~ m[^http://] or $homeurl =~ m[^https://]) {
&inerror("Your home url has to start with http:// or https://");
}
which to me feels like it more clearly conveys what's meant here.
Finally, though, I want to suggest, in this specific instance, to use the ? quantifier:
unless ($homeurl =~ m[^https?://]) {
&inerror("Your home url has to start with http:// or https://");
}
____________Makeshifts last the longest.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|