comment on

I'm now using the below. Anyone see any problems? Should I still use truncate($fh, 0); after seek or does the sysopen take care of that?

sub safe_open {
    my $fn = shift;
    $fn =~ s/^(>>?)//;
    $mode = length($1);
    my $flags = $mode == 1 ? O_CREAT | O_WRONLY | O_TRUNC  :
                $mode == 2 ? O_CREAT | O_WRONLY | O_APPEND :
                O_RDONLY;
    sysopen(my $fh, $fn, $flags) or die "Can't open $fn: $!";
    if ($flock_enabled) {
        flock($fh, LOCK_EX) or die "Can't flock $fn: $!";
    }
    seek $fh, 0, 0;
    return $fh;
}
[download]

In reply to Re: Re: Safe way to open files by L0rdPhi1
in thread Safe way to open files by L0rdPhi1

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Think about Loose Coupling
	PerlMonks