I'd certainly drop the && do { ... redo } hack which I find to be not even close to worth the "surprise" factor (plus the maintainance problems of not noticing when you forget a "redo"). And I'd add a different hack (single-argument for) which I think offers a big win in this specific case:
for( $self->{gamedescr}{Game} ) {
while( ! m/\G\z/mgc ) {
if( m/\G($REnumber)\s*/mgc ) {
my $num=$1;
#...
} elsif( m/\G($REanymove)\s*/mgc ) {
push @{$self->{GameMoves}}, $1;
$color = $switchcolor{$color};
} elsif( m/\G($REcomment|$REeolcomment|$RERAV|$RENAG|$REe
+scape)\s*/mgc ) {
#...
} else {
die "Invalid input...";
}
}
}
-
tye
(but my friends call me "Tye")
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|