It looks like this is intended to be a CGI, and yet it doesn't emit the correct response header, so I'll assume this is just a code fragment.

What, exactly, do you expect   @p{'eyes', 'hair', 'etc'} =(); to do? It rather looks like a syntax error to me. If you're trying to pre-load a hash with keys, you might try

  my %p;
  $p{$_} = undef for qw(eyes hair etc);
[download]

But that begs the question of what your do_print is trying to do, since   @p{ 'eyes', 'hair', 'etc' } results in a three element array, with each element being undef. Assuming that you're trying to return the heading if and only if any one of the elements is present, you could do

  sub do_head {
       my($heading, @data) = @_;

      return "<h4>$heading</h4>" if grep { defined($_) } @data;
      return "";
  }
[download]

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.