I know this does not help your actual error, but in the interest of security, there are a few things ...
- dont trust the user
- dont trust the user
- and, dont trust the user
I would suggest doing a few things. For each of the m//i's in the if/else, i suggest using lc(), and then using eq ... this prevents evil hacker code man motd from matching m/motd/i. Also, on the non-trusted user front, having the command coded in is very good, but i would think that the environment could have some very usefull information in it, were the wrong person to be pokiing around. This best thing to do, in the short term, is design a protocal for logging in (something as simple as FTP's login procedure).
Lastlky, on the error, i do not believe programs like motd use \r\n for newlines, so it is possible that is causing some issues.
$ perl -e 'do() || ! do() ;'
Undefined subroutine &main::try
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|