No, I would not.
It sounds like you have a top-level dispatch table, but
(like a tree) you have a lower-level set of dispatches
that need to happen on some nodes on specialized information. And what you are doing is handling special cases with a goto which will make it harder later to figure out, "How did I get here?" so that some subroutines can do double-duty.
Instead I would operate as follows:
sub dispatch_edit_product {
my $query = $_[0];
if ($query->param("officeID")) {
edit_office_product(@_);
}
else {
edit_generic_product(@_);
}
}
sub edit_generic_product {
my ( $query, $db, $mod, $sec ) = @_;
# ...
}
sub edit_office_product {
# ...
}
And now you leave complete call information for your debugging routine to report, and every function in the call stack makes perfect sense.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|