The OP did update his data here.
A nit, but I think he wanted the anon array 'Answers' to be an array of hash refs.
He was concerned about creating a hash too large for memory. :-)
If the 'ids' were only 1 to 4, this wouldn't be a problem. But if the different 'ids' were in the thousands or so, I think that was what he what he wanted to avoid. You do reuse hash keys for this small example.
There was only 1 repeated id in his data, and this is where it is reused.
The test for 'exists' therefore tests true for this id only and output gets called. The rest of the output gets done outside the while loop (#remaining).
Your code outputs (on his revised data with my ($s1,$n,$s2,$v2,undef) = split ';',$_,5; changed to my (undef,$s1,$n,$s2,$v2) = split ';',$_,5;):
{"ip":["2.3.4.5","2.3.4.5"],"id":"2","host":"www.cnn.com"}
{"ip":["3.4.5.6","1.2.4.5"],"id":"4","host":"www.google.com"}
{"ip":["1.2.3.4"],"id":"1","host":"www.example.com"}
{"ip":["3.4.5.6"],"id":"3","host":"www.google.com"}
{"ip":["2.3.4.5"],"id":"2","host":"www.example2.com"}
I coded a similar solution to you (only difference being an array of hashrefs instead of values alone).
{"id":"1","Answer":[{"ip":"1.2.3.4"}],"host":"www.example.com"}
{"id":"2","Answer":[{"ip":"2.3.4.5"},{"ip":"2.3.4.5"}],"host":"www.cnn
+.com"}
{"id":"3","Answer":[{"ip":"3.4.5.6"}],"host":"www.google.com"}
{"id":"4","Answer":[{"ip":"3.4.5.6"},{"ip":"1.2.4.5"}],"host":"www.goo
+gle.com"}
{"id":"2","Answer":[{"ip":"2.3.4.5"}],"host":"www.example2.com"}
My solution was:
#!/usr/bin/perl
use strict;
use warnings;
use JSON;
open my $fh, '<', 'file2' or die $!;
my %query;
while (<$fh>) {
chomp;
my (undef, $cat, $id, undef, $val) = split /;/;
if ($cat eq 'Query') {
if (%query) {
output(\%query);
%query = ();
}
$query{$id} = [$val];
}
else {
push @{ $query{$id} }, {ip => $val};
}
}
output(\%query);
sub output {
my $query = shift;
my ($id) = keys %$query;
my $host = shift @{ $query->{$id} };
print encode_json({Answer => $query->{$id}, id => $id, host => $ho
+st}),"\n";
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.