Other Monks have pointed out the errs in your ways, so I won't go there, I'll just expand... I would personally use Archive::Extract so your code doesn't have to shell out. Said module has been part of perl's core since pre-v5.10. Also note that I use a file glob (<*.ext>) to slurp in the file names, which retain their full path information (this eliminates another system call (ls)). Here's an example:
use warnings;
use strict;
use Archive::Extract;
my $inputs = "~/inputs";
my $results = "/home/steve/results";
my @files = <$inputs/*.tar.gz>;
for (@files){
my $ae = Archive::Extract->new(archive => $_);
$ae->extract(to => $results)
or die "couldn't decompress the damned $_ file!: " . $ae->error;
print "decompressed $_\n";
}
For some reason, extract() wouldn't recognize the homedir shortcut, so I just entered in the full path. I'm sure it can expand it somehow, I just don't have the time to troubleshoot.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|