This code looks pretty good, at least at a first glance. You use heredocs in some places, but not in others. It would be good to use them everywhere.
The biggest thing that jumps out is that you are not testing whether open succeeds or fails. Also, the data files appear to be in the same directory as the CGI script. This is definitely not a clever idea. Put them under your home directory, or something, but get them out from under the web document tree.
Finally, if you want to try this out on a webserver, if you ask jcwren nicely he'll give you an account on perlmonk.org.
--g r i n d e r
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
