comment on

I think you have some valid concerns, especially if this is code you're working in tandem with.

I think you need to take the human approach here and just ask the person that wrote it or is maintaining it.

"Hey $author, I was taking a look at this code you wrote and I was curious why you did $thing this way?"

This way, it's not confrontational, and they don't really have an excuse to get defensive. You're there purely for educational purposes. I've found a lot of times people get kind of a sheepish look and go "yeaaaa it's really bad code, sorry, I was in an enormous rush etc." If they try to justify it with something stupid, well, you have your answer then.

Three thousand years of beautiful tradition, from Moses to Sandy Koufax, you're god damn right I'm living in the fucking past

In reply to Re: Advice on best practices by stonecolddevin
in thread Advice on best practices by goldcougar

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Perl: the Markov chain saw
	PerlMonks