hippo, thanks! I had some time this morning, and started improving the code based on your comment. While there's still a lot of work to do, I added a method:
sub write_list_to_logfile {
my ( $list, $logfile ) = @_;
open my $file, '>', $logfile or die "Can't open $logfile: $!";
foreach my $line ( @$list ){
print $file "$line\n";
}
close $file;
}
And then changed the logging method to use the new method:
if ( keys(%known_dirs) ) {
my @known_dirs = keys(%known_dirs);
my $known_dirs_filename = "$dir/known_dirs.list";
write_list_to_logfile(\@known_dirs, $known_dirs_filename);
}
The new method works, but I ran out of time before I could streamline it more. I'm thinking I can eliminate the two assignments, but need to test the idea.
Chronicler: The Domici War (domiciwar.net)
General Ne'er-do-well (github.com/LeamHall)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|