if ( my $line = readline( $self->{file_handle} ) ) {
return $line;
} else {
return;
}
I appreciate old-school, but I think the quoted code will fail to
return the last line of a file if it is '0' with no
terminating newline. I haven't tested it, but wouldn't
if (defined(my $line = readline( $self->{file_handle} ))) {
return $line;
} else {
return;
}
or even just
return readline($self->{file_handle});
( readline returns undef at eof) be better?
Give a man a fish: <%-{-{-{-<
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|