comment on

I made a few changes to the conditionals around the eval code to possibly keep mistakes from happening when it is used, but I still can't figure out how to convert the eval EXPR into an eval BLOCK. Like converting a map or grep EXPR to a BLOCK, it isn't as easy as putting {} around it instead of () and expecting it to work the same.

  if ($raw_value && $raw_value =~ /\d+\*\d+/) {
    $total_value = eval($raw_value); # performs multiplication
    ($amount, $base_value) = split(/\*/,$raw_value);
  }
  elsif ($raw_value && $raw_value =~ /\d+\/\d+/) {
    $base_value = eval($raw_value); # performs division
    ($total_value, $amount) = split(/\//, $raw_value);
  }
  else {
    $amount = $raw_value;
    $base_value = $assets->{$lookup_asset} ? $assets->{$lookup_asset} 
+: 0;
    $total_value = $amount * $base_value;
  }
[download]

My OS is Debian 10 (Buster); my perl versions are 5.28.1 local and 5.16.3 or 5.30.0 on web host depending on the shebang.

No matter how hysterical I get, my problems are not time sensitive. So, relax, have a cookie, and a very nice day!

Lady Aleena

In reply to Re^3: Perl::Critic says don't modify $_ in list functions and other things by Lady_Aleena
in thread Perl::Critic says don't modify $_ in list functions and other things by Lady_Aleena

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.


Don't ask to ask, just ask
	PerlMonks