Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Your override can be written more simply:

my %obj_cache; override 'new' => sub { my ( $class, @args ) = @_; my $params = $class->BUILDARGS(@args); $obj_cache{$params->{thingy}} ||= $class->_new($params); };

As you're potentially not creating a new object, but returning a cached object, I don't think Class->instance(%args) is a bad name for the method call. new would be a misnomer.

What if I change my mind about caching, or want to debug the code without the cache? Then I have to find all the calls in all my code and change them.

No, you wouldn't need to change all the calls. You'd just need to change the instance method to always return a new object:

sub instance { shift->new(@_) }

One of the things I'm encouraging in Zydeco is the idea that the new method should be considered internal to the class, and the class should provide factory methods for external code to call. And it's for this kind of reason — it allows the class to do things like return cached objects, or a singleton, or whatever.


In reply to Re: Override new in Moose for flyweight objects by tobyink
in thread Override new in Moose for flyweight objects by Aaronrp

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others surveying the Monastery: (2)
As of 2024-04-25 22:44 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found