Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
Is there such a policy?

Here's one :-)

package Perl::Critic::Policy::ControlStructures::ProhibitGotoLabel; use warnings; use strict; use base 'Perl::Critic::Policy'; use Perl::Critic::Utils qw/:severities/; # to locate the path where to place this file, do e.g.: # $ perl -MFile::Basename=dirname -MPerl::Critic::Policy::ControlStruc +tures::ProhibitUnreachableCode -le 'print dirname $INC{"Perl/Critic/P +olicy/ControlStructures/ProhibitUnreachableCode.pm"}' # or # $ dirname `perldoc -l Perl::Critic::Policy::ControlStructures::Prohi +bitUnreachableCode` our $VERSION = '0.001'; sub supported_parameters { return } sub default_severity { return $SEVERITY_MEDIUM } sub default_themes { return qw/core bugs/ } sub applies_to { return 'PPI::Token::Word' } =head1 DESCRIPTION A C<goto LABEL> is considered a bad practice by a number of people, as it can lead to hard-to-understand and brittle spaghetti code. Instead of a C<goto>, use different control structures, or place a label on a block (such as a loop's block) and use C<next LABEL>, C<last LABEL>, or C<redo LABEL> instead. C<goto &NAME> is very different from C<goto LABEL> and is not covered by this policy. C<goto EXPR> is ambiguous and this policy will report such cases when C<EXPR> does not begin with C<&>. Whether this is a false positive or not cannot be determined by a static parse. =cut my $DESC = q{goto LABEL used}; my $EXPL = q{Considered bad practice}; sub violates { my ($self, $elem) = @_; return if $elem->content() ne 'goto'; my $target = $elem->snext_sibling(); return $self->violation('Nothing following "goto"?', 'It seems there is a lone "goto" in your code?', $elem) if !$target; return if $target->isa('PPI::Token::Symbol') && $target->raw_type +eq '&' || $target->isa('PPI::Token::Cast') && $target->content +eq '&' || $target->isa('PPI::Token::Word') && $target->content +eq '__SUB__'; return $self->violation($DESC,$EXPL,$elem); } 1;

Test code:

#!/usr/bin/env perl use warnings; use strict; use feature 'current_sub'; # Perl 5.16, for __SUB__() # tests for Perl::Critic::Policy::ControlStructures::ProhibitGotoLabel # run me with e.g.: perl -c gototest.pl && perlcritic -3 gototest.pl goto FOO; # bad FOO: sub foo { } sub bar { goto &foo } # good my $i = 1; goto ("FOO", "BAR", "GLARCH")[$i]; # bad BAR: sub quz { goto __SUB__ } # good sub quz2 { goto __SUB__() } # good my $subref = \&foo; sub ab { goto &$subref; } # good sub cd { goto $subref; } # good, but false positive my $label = "XYZ"; goto $label; # bad (but ambigious) XYZ: __END__ gototest.pl syntax OK goto LABEL used at line 9, column 1. Considered bad practice. (Sever +ity: 3) goto LABEL used at line 16, column 1. Considered bad practice. (Seve +rity: 3) goto LABEL used at line 24, column 10. Considered bad practice. (Sev +erity: 3) goto LABEL used at line 27, column 1. Considered bad practice. (Seve +rity: 3)

Update: Added handling of __SUB__ keyword, thanks rir!


In reply to Re: Go to perl::critic (updated) by haukex
in thread Go to perl::critic by rir

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others romping around the Monastery: (6)
As of 2024-04-25 18:06 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found