Munging my C code, here is one that is faster, though not simpler:
sub divisors {
my($n,@f) = @_;
my @d = (1);
while (@f) {
my $p = shift(@f);
if (!@f || $p != $f[0]) {
# Factor appears once. Multiply through.
push @d, map { $p * $_ } @d;
} else {
my $e = 1;
do { shift(@f); $e++; } while @f && $p == $f[0];
# Factor appears $e times. Multiply through p, p^2, p^3, ...
my @t = @d;
for (1 .. $e) {
@t = map { $p * $_ } @t;
push @d, @t;
}
}
}
@d = sort { $a <=> $b } @d;
@d;
}
I'm basically converting to factor/exponent form, then pushing the divisors on the list. Doing it by prime factor means we avoid duplication so no need for hashes. Improvements welcome.
An aside, we can see some expected results using something like:
perl -MMath::Pari=divisors -E 'for my $n (1..1_000_000) { my $d = divisors($n); print "$n @$d\n"; }'
or
perl -Mntheory=divisors -E 'for my $n (1..1_000_000) { my @d = divisors($n); print "$n @d\n"; }'
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|