Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

I think you may have some flawed logic in your "searchfile" subroutine. You have:

foreach my $k ( keys %master ) { while ( my $line=<$foundfile> ) {

At the end of the first iteration through the foreach loop, you will have checked every line in the file. But every iteration of the foreach loop after that won't execute the while loop.

One option to is to open the file inside the foreach loop and then work through the while loop and then close the file in each iteration like this:

sub searchfile { my $file=shift; # print "open $file\n"; foreach my $k ( keys %master ) { open my $foundfile, '<', $file or die "can't open $file"; my $first=<$foundfile>; while ( my $line=<$foundfile> ) { if ($line =~ m/$k/ ) { $master{$k}++ ; # print "$k found in $file\n"; } } close $foundfile; } }

That's basically doing this. For every key in the hash, do the following: open the file, skip the first line, search the rest of the lines for the key (and do action if found) and close the file

Another option is to swap your foreach and while loops like this:

sub searchfile { my $file=shift; # print "open $file\n"; open my $foundfile, '<', $file or die "can't open $file"; my $first=<$foundfile>; while ( my $line=<$foundfile> ) { foreach my $k ( keys %master ){ if ($line =~ m/$k/ ) { $master{$k}++ ; # print "$k found in $file\n"; } } } close $foundfile; }

This is basically doing the following: open the file, skip the first line, then for each line check to see if the matches any of the keys in the hash (and if it does, do some action) and then closes the file.

Not knowing more information about your files and their contents, I think I would personally opt to go the second route, which only opens each file once.


In reply to Re: Making sense of File::Find by dasgar
in thread Making sense of File::Find by wazoox

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (4)
As of 2021-10-25 13:36 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    My first memorable Perl project was:







    Results (89 votes). Check out past polls.

    Notices?