The first thing to do when you start a script is use strictures:
#!/usr/bin/perl
use strict;
use warnings;
When you finish the script, run it through
Perl::Tidy:
#!/usr/bin/perl -l
use strict;
use warnings;
my (@gilligan) = qw(
red_shirt
hat
lucky_socks
water_bottle
);
check_require_items( 'gilligan', @gilligan );
sub check_require_items {
use strict;
use warnings;
my $who = shift();
my (%whos_items) = map( { $_, 1; } @_ );
my (@required) = qw(
preserver
sunscreen
water_bottle
jacket
);
foreach my $item (@required) {
unless ( $whos_items{$item} ) {
print "$who is missing $item.";
}
}
}
It's easier to read, no?
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|