comment on

Ahem, I took another look at the game, just ignore my previous rambling.
Discovered the following though:

} elsif ($get =~ /MESSAGE ([^ ]+) (.*)\n$/) {
[download]

This pattern can never match since the line is chomped?

Why is Tk::repeat necessary, what happens if it's omitted?
Update: ah, I see it now. Why don't you modify get_line to return all lines available if wantarray?
Process could then do ... for my $get (get_line($server)) {} ...

Just a note: sysread() can return any number of bytes, length being the limit.
Give "ip link set eth0 mtu 60" on the server, for some short-packet fun.

~~Loop the sysread(), or recurse into get_line.~~

Update. TCP.pm in the git, does it not read as follows:

sub get_line {
    my ($fh) = @_;
    warn "Getting from $fh\n";
    my $line = read_from_buffer($fh);
    return $line if defined $line;

    if (sysread $fh, my $read, BUFF_SIZE) {
        warn "sysread $read";
        $buff{$fh} .= $read;
    }
    $line = read_from_buffer($fh);
    warn "Got $line\n";
    warn do { use Data::Dumper; Dumper $buff{$fh} };
    return $line;
}
[download]

I would simply write (untested):
sub get_line { my ($fh) = @_; warn "Getting from $fh\n"; my $line = read_from_buffer($fh); return $line if defined $line; sysread($fh, $_, BUFF_SIZE, length) for $buff{$fh}; return get_line($fh); }
[download]

In reply to Re: A Game Using TCP Sockets by oiskuu
in thread A Game Using TCP Sockets by choroba

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


There's more than one way to do things
	PerlMonks