Re: Mysql and Perl Module

First of all: take the whole setting up out of the subroutine and into the main body of that script. That includes the DBI->connect stuff and preparing a statement handle.
This will make your script much faster because you don't keep reconnecting for every single row you want to insert. Same for the preparation of the statement handle. Prepare it once and pass the handle around (into the subroutine).
The next thing you should look up is how to use placeholders in your statement (questionmarks in the statement that are bound to values in the execute method.
Then there is the question of what it means if you have less than the full set of values in one row of your csv file. I guess those are "NULL" in your database, so you justneed to ensure that those values are "undef", which will insert them as NULLs.

Comment on Re: Mysql and Perl Module

Replies are listed 'Best First'.
Re^2: Mysql and Perl Module by endymion (Acolyte) on Jun 14, 2012 at 08:41 UTC
Hello Tospo, the problem is it should be an module we can use for all of our customer scripts. The point is, that we need a module where I can only give a few arguments to it. Is it better to make another sub for the connection ?	[reply]
Re^3: Mysql and Perl Module by Anonymous Monk on Jun 14, 2012 at 09:26 UTC
See this example program Re: Open multiple file handles? You can easily create a module with a function like this sub IntoDbImportCSV { my( $dbiconn, # dbi connection string $colnames, # column names $csvfile, # path to csv file $csvargs, # Text::CSV->new options hash ) = @_; my $dbh = DBI->connect( $dbiconn, undef, undef, { RaiseError => 1, PrintError => 1, }, ); open my($infh), '<', $csvfile ... my $csv_in = ... $dbh->begin_work; my $sth = $dbh->prepare($sql); while ( my $row = $csv_in->getline( $infh ) ) { $sth->execute( @{ $row } ); } $dbh->commit; $dbh->disconnect; } IntoDbImportCSV( 'dbi:SQLite:dbname=temp.test.sqlite', '/path/to/foo.cvs', ['ro', 'sham', 'bo' ], { quote_char => '"', sep_char => ',', allow_loose_escapes => 1, empty_is_undef => 1, binary => 1, auto_diag => 1, }, ); [download]	[reply] [d/l]
Re^3: Mysql and Perl Module by tospo (Hermit) on Jun 14, 2012 at 09:29 UTC
The ideal situation for that scenario is that your module takes some sort of config file with the DSN for the databse connection so that you can ship it with a tailor-made config file for each of your customers. Look at something like Config::General to handle such a config. Alternatively, you could make the DSN an argument that needs to be supplied by the user when running this script. If you have a lot of stuff to do with that database then it would also be worth exploring something like DBIx::Class to handle your database in a much more abstract way.	[reply]


We don't bite newbies here... much
	PerlMonks