Just another Perl shrine | |
PerlMonks |
Re: Seeking feedback on Tic-Tac-Toeby synapse0 (Pilgrim) |
on Jul 12, 2001 at 03:20 UTC ( [id://95886]=note: print w/replies, xml ) | Need Help?? |
Ok, aside from -Tw and use strict; here's a few other suggestions.. In your param snarfing part, you might want to use something that works with defaults.. for example: CGI::Carp would be a good thing for error reporting (where the file open may die). You open files inside if (param()) { but try and close them outside of the block.. it wont error, but it's ugly. and lastly, probably more of a nitpick, you have a ton of file opening and closing.. there's probably a better way to handle that (like rewinding file) -Syn0
In Section
Seekers of Perl Wisdom
|
|