Accessing an executable from perl script

abcdefg has asked for the wisdom of the Perl Monks concerning the following question:

Hi There, I have a client server application in which client sends an input file to server ,server uses a tool called abc.exe on that input file, which gives an output file and sends it back to client.The name for the output file is basically output_input file.if the output file with the same name is already present then it increments the suffix at each run. I have written this code but its not working correctly.I guess there is some problem with the $abc_cmd.Can anyone tell me what I am doing wrong?


              
        # Setup some default filenames and command strings.
        my $input_file;
        my $output_file = "output.$input_file";
        my $rcv_filesize;
        my $abc_cmd;
        my $buf;
        my $error = "ACK\n";
      
       $rcv_filesize = 0;                
       my $i = 1;
       while (-e $output_file) {
      $output_file = "output.$input_file$i";
                $i++;
                }
      $abc_cmd = "abc.exe" -i $input_file -o $output_file"; 
      print $client_socket "ACK\n";


    system $abc_cmd;     # Run the command
        print "DONE\n";
        
        # Open the file for reading 
         open(INFILE, $output_file) || die "ERROR:  Could not open out
+put_file for reading!\n";
        binmode INFILE;
        {
            local $/;
            $output_data = <INFILE>;
        }
        close(INFILE);

        print "$prefix Sending $output_file to the client... ";
        $client_socket->write($output_data, length($output_data));
        
        print length($output_data), " bytes: DONE\n";
        
        $client_socket->close();
        print "$prefix Socket closed, operation completed!\n";
[download]

Comment on Accessing an executable from perl script Download Code

Replies are listed 'Best First'.
Re: Accessing an executable from perl script by onelesd (Pilgrim) on Mar 01, 2012 at 22:50 UTC
`system($abc_cmd) == 0 or die $! ;`	[reply] [d/l]
Re: Accessing an executable from perl script by JavaFan (Canon) on Mar 01, 2012 at 22:47 UTC
`$abc_cmd = "abc.exe" -i $input_file -o $output_file";` This doesn't compile. `system $abc_cmd;` You're neither checking the return value of `system`, nor are you checking `$?`. If you expect you have a problem with `$abc_cmd`, checking those values is something you ought to be before asking others to debug your program.	[reply] [d/l] [select]
Re^2: Accessing an executable from perl script by Anonymous Monk on Mar 01, 2012 at 23:00 UTC
so if you're looking fo help debugging your code you better make sure to debug it first?	[reply]
Re: Accessing an executable from perl script by kcott (Archbishop) on Mar 02, 2012 at 09:30 UTC
To get the error status from `$abc_cmd`, you can write: `system($abc_cmd) and die $? >> 8;` [download] You can inspect `$?` in other ways: see system. There are other variables you may want to check: see perlvar - Error Variables. -- Ken	[reply] [d/l] [select]
Re^2: Accessing an executable from perl script by dpetrov (Acolyte) on Mar 02, 2012 at 15:17 UTC
or using some module like autodie could be handy, here is a link https://metacpan.org/module/autodie	[reply]


Welcome to the Monastery
	PerlMonks