Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re^3: Filling in missing values in an array

by FunkyMonk (Chancellor)
on Jun 29, 2011 at 16:37 UTC ( #911994=note: print w/replies, xml ) Need Help??

in reply to Re^2: Filling in missing values in an array
in thread Filling in missing values in an array

Though I'm not quite sure how tests 3-5 are supposed to go
Neither was I! So I made it die (a.k.a throws an exception) when the array consists only of NULLs. Garbage in, garbage out, as we used to say. Exceptions prevent the garbage leaking out.

If you decide it should do something other than die, just change this line:

die "No values found" if @arr && 0 == grep $_ ne '_', @arr;

Replies are listed 'Best First'.
Re^4: Filling in missing values in an array
by Neighbour (Friar) on Jun 30, 2011 at 06:39 UTC
    Yea, but when it dies, the tests are never executed (in my case). That's probably not what's supposed to happen :).
      If you don't want the code to die, you need to use something to catch the exception. I like Try::Tiny:
      use Try::Tiny; my @bad = try { fill_in_the_blanks(qw<_ _ _>) } # fails catch { print "bad data!\n" }; my @good = try { fill_in_the_blanks(qw<_ 1 _>) } # succeeds catch { print "bad data!\n" };
      Ah, found out where things went wrong:
      My code dies with a 'No values found' for is_deeply [fill_in_the_blanks(qw< >)], [qw< >], "( )";.
      I thought that throws_ok didn't catch the die but that wasn't the case.
      Seems our approach of the 'empty array'-situation differs :)

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://911994]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (2)
As of 2021-10-16 00:12 GMT
Find Nodes?
    Voting Booth?
    My first memorable Perl project was:

    Results (69 votes). Check out past polls.