#!/usr/bin/perl -w

$|++;

print "Hello before fork\n";      #print first message
$thiscount = 0;            #counter for number of forks
for($i = 0; $i < 2; $i++)    #for loop to fork 2 procs
{
    $thispid = phork();    #fork a proc, store the pid
    print "Just forked $thispid\n";  #tell us what you've done
    $thiscount++;        #increment the fork count
}

$wpid = wait;            #wait until children are finished
print "i'm waiting on $wpid\n"; #tell us what you've done

print "hello from after fork.  I have forked $thiscount child processe
+s.\n";  #final message from parent?


sub phork()             #subroutine for forking stuff
{
    $cid = 0;        #child id
    $count = 0;        #number of times through.
    FORK:
    {
        print "i am about to start forking stuff.  my id is $$, and i 
+have done this $count times\n";
        $count++;    #increment the number of times through
        if($pid = fork())    #parent process
        {
            print "Parent phorking child.  I am: $$, and my child is $
+pid\n";
            $cid = $pid;
        }
        elsif(defined $pid)    #child processs
        {
            print "Hello from in phork.  I am $$, and my parent is: $p
+id\n";
            return $$;
        }
        elsif($! =~ /No more process/)    #error
        {    
            sleep 5;
            redo FORK;
        }
        else    #error
        {    
            die "Cant phork: $!\n";
        }
            
    }
    return $cid;    #ship back the child id
}
[download]

[33] rk110759@sunray22: test.pl
Hello before fork
i am about to start forking stuff.  my id is 15092, and i have done th
+is 0 times
Parent phorking child.  I am: 15092, and my child is 15095
Just forked 15095
i am about to start forking stuff.  my id is 15092, and i have done th
+is 0 times
Parent phorking child.  I am: 15092, and my child is 15096
Just forked 15096
Hello from in phork.  I am 15096, and my parent is: 0
Just forked 15096
Hello from in phork.  I am 15095, and my parent is: 0
Just forked 15095
i am about to start forking stuff.  my id is 15095, and i have done th
+is 0 times
i'm waiting on -1
hello from after fork.  I have forked 2 child processes.
Parent phorking child.  I am: 15095, and my child is 15097
Just forked 15097
Hello from in phork.  I am 15097, and my parent is: 0
Just forked 15097
i'm waiting on -1
hello from after fork.  I have forked 2 child processes.
i'm waiting on 15097
hello from after fork.  I have forked 2 child processes.
i'm waiting on 15095
hello from after fork.  I have forked 2 child processes.
[download]

First, inside phork(), you incorrectly try to get the parent id from within the child. Going by the Camel, 3rd ed., p. 715, the following change should be made:

   elsif(defined $pid)    # Quoth the Elders: 
                          # "$pid is zero here if defined"
        {
         print "Hello from in phork. "
         print "I am $$, and my parent is: " 
            . getppid ."\n";
         return $$;
        }
[download]

Secondly, you've already seen the others' comments on the problem with the children re-entering the loop and spawning their own children. Here's my take on what you can do to fix it. (I'm posting this as much to help you as to get told by others if it's a horrible idea, so caveat coder...)

use strict;           
$|++;
my $parent_id = $$;    # Before forking, save the $parent_id
my $totalcounts = 0; 
for(my $i = 0; $i < 2; $i++)   # for loop to fork 2 procs
  {
      print "[$totalcounts == $i]\n";  # just to check...
 
      # if I am the parent...
      if ($$ == $parent_id) {          
          #...fork a proc and store the pid
          my $thispid = phork(); 
      }

      # I have now forked.  If I am NOT the parent...
      if ($$ != $parent_id) {   ## Note 'if'. An else/elsif 
                                ## WON'T work here! The 
                                ## kids would skip this.
          #...do whatever I want to do, but when done:
          exit; 

          # Now the children have been stopped 
          # before they could continue along the $i loop.
      }   
      $totalcount++;        #increment the fork count
  }
[download]

Alternatively, add the exit() at the appropriate spot in phork().

-- Frag.

Okay, this may be difficult to follow along to; but I will do my best.

When you fork, your children processes get an exact replica of the process. So, your first child gets spawned. Now, it has a copy of $i which has the value zero. So, it is spawned, it runs the phork() subroutine, and it returns to the for loop with a $i of 0. So, it beings to execute the loop; and your first child process forks its own child and that child (the first child of the first child of the parent) is spawned and it gets a copy of the memory block who has a $i of 1. This stuff happens some more with the second child of the parent and so on. What you want is something along these lines: (warning: untested)

#!/usr/bin/perl -w
use strict;

my $childLimit = shift @ARGV; #get total number of children
my @pids = (); #array of pids of children

for(my $i = 0; $i < $childLimit; $i++)
{
    if( !( $pids[$i] = fork() ) )
    {
        # in the child
        callChildSub();

        exit(0); # exit from the child process IMPORTANT
    } 
}

foreach my $pid (@pids)
{
    waitpid $pid, 0;
}

sub callChildSub()
{
    print "I am the child with pid $$.\n";
}
[download]

Of course, that needs some error-checking and such, but that should get you started.

Jeremy

Because your child *returns* (after it has done the printing) into the for loop, thereby (next iteration) phorking itself a child - and 2x2 makes 4. BTW it should exit or die"\n".