http://qs321.pair.com?node_id=860867

pjfl has asked for the wisdom of the Perl Monks concerning the following question:

Following these instructions this is call out to the Catalyst::Plugin::Log::Handler module author. Would you respond this RT ticket please? TIA
  • Comment on Catalyst::Plugin::Log::Handler - Pinging module author

Replies are listed 'Best First'.
Re: Catalyst::Plugin::Log::Handler - Pinging module author
by MidLifeXis (Monsignor) on Sep 20, 2010 at 16:51 UTC

    It seems to me as if the patch caused some tests to fail (at least according to the email chain). Perhaps addressing the cause of those test failures within the patch would help to move this along / at all?

    Update: unintentionally snarky.

    --MidLifeXis

      Have you tried applying the patch and running the tests? Worked for me the last time I tried it so I suspect that the post to which your refering is incorrect

        So have you addressed the responder? That user is the one that had failures in the test. Working on one system (or even one set of systems) does not mean that it is a good patch. That is the reason for cpantesters and the like.

        My point is this: the documentation that you have provided does not (IMO) justify taking over the distribution from the original author. Taking over the distribution is a very large mallet when a finishing hammer may be all that is necessary. A single instance of a patch not being applied is not (again, IMO) justification for taking over a distribution.

        However, I am not saying that the module should not be taken over. Just that the information you have provided does not justify it, and that there may be a better, less confrontational way of addressing it. Perhaps you have already attempted one or more other methods, but just not demonstrated that you have.

        --MidLifeXis

Re: Catalyst::Plugin::Log::Handler - Pinging module author
by Anonymous Monk on Sep 22, 2010 at 14:38 UTC

    Hi,

    sorry for my slow responses.. (I am the module author).

    I'm going to get your patch into the module. If you would like to adopt the module, I'll give it to you, as I am not currently working on projects that use Catalyst.

      (That anonymous post was by me)

      pjfl, could you confirm that CPLH 0.07_01 works for you?

      Update: Uploaded 0.08 with the dependencies fixed. Thank you for your help.

        Many thanks that works just fine.

        Update: Except the Build.PL needs updating to reflect the change in dependency from NEXT to MRO::Compat

Re: Catalyst::Plugin::Log::Handler - Pinging module author
by bloonix (Monk) on Sep 22, 2010 at 14:25 UTC

    Hi,

    I pinged the author on irc.perl.org and I'm in the hope that he's answered soon ;-)

    Give him some time.

    Cheers,
    Jonny