I would just have used map to make that a lot more simple:

print map { "$_|" } @my_list
[download]

And a design pattern that you should start to recognize is that as soon as you see the concatenation operator, you should be thinking about changing that to a list. So

$my_id_list .= $my_list[$i]."|";
[download]

push ( @my_id, "$my_list[$i]|" );
[download]

And if your code also removes the last "|" from the strong that you're building, then you can do

push ( @my_id, $my_list[$i] );
[download]

join('|',@my_id);
[download]