Re: Skip 21 Lines

You all have great comments. How would I incorporate any one of those code snippets into the following code:

open (DATA, "<file.txt") or die "Can't open file $!\n";
my @DATA = <DATA>;
close (DATA);

foreach $rec (@DATA) {
    chomp $rec;
    ($var1, $var2, $var3, $var4) = split(/,/,$rec);
    $var1 =~ s/\s+$//g;
    $var1 =~ s/"//g;
    $var2 =~ s/\s+$//g;
    $var2 =~ s/"//g;
    $var3 =~ s/\s+$//g;
    $var3 =~ s/"//g;
    $var4 =~ s/\s+$//g;
    $var4 =~ s/"//g;
          $compHash{$var1} = $var2;
    $aliasHash{$var3} = $var1;
}
[download]

This code works great, just needs to skip the first 21 lines.

qball~"I have node idea?!"

Comment on Re: Skip 21 Lines Download Code

Replies are listed 'Best First'.
Re: Re: Skip 21 Lines by turnstep (Parson) on Apr 24, 2001 at 20:28 UTC
`open (DATA, "<file.txt") or die "Can't open file $!\n"; <DATA> while $. < 21; my @DATA = <DATA>; close (DATA);` [download]	[reply] [d/l]
Re: Re: Re: Skip 21 Lines by MeowChow (Vicar) on Apr 25, 2001 at 11:24 UTC
Nice use of an obscure variable (the obfuscator in me salutes you), but you'd better hope that the file is at least 22 lines long, or you'll be waiting quite a while for your data :-) MeowChow s aamecha.s a..a\u$&owag.print	[reply]
Re: Re: Re: Re: Skip 21 Lines by turnstep (Parson) on Apr 25, 2001 at 17:56 UTC
Point taken (although I don't think of $. as particularly obscure.) Slight modification: `1 while <DATA> and $. < 21;` [download]	[reply] [d/l]
Re: Re: Skip 21 Lines by greenFox (Vicar) on Apr 25, 2001 at 04:22 UTC
You are repeating quite a bit of code there :) Try this (partially tested)- my $file = 'file.txt'; # open for input is default and now our die tells us which # file we were trying to open open (DATA, $file) or die "Can't open $file $!\n"; # assuming you aren't using @DATA for something else later # there is no need to slurp it all into memory now while (<DATA>) { next unless $. > 21; chomp; my @temp=(); foreach (split /,/){ s/"//g; # strip the quotes first if you want s/\s+$//; # to remove trailing whitespace push @temp, $_; } $compHash{$temp[0]} = $temp[1]; $aliasHash{$temp[2]} = $temp[3]; # you did mean $var4? } close (DATA); [download] I am sure it could be reduced further with a judicious use of map but I can't get my head around it this morning :( Since you are parsing quoted CSV data you may want to look at Text::CSV which is a standard module or tilly's Text::xSV which is also available from CPAN. -- my $chainsaw = 'Perl';	[reply] [d/l]


Pathologically Eclectic Rubbish Lister
	PerlMonks