Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re: Joining Arrays?

by Lawliet (Curate)
on Dec 20, 2008 at 21:40 UTC ( [id://731812]=note: print w/replies, xml ) Need Help??


in reply to Joining Arrays?

Well, without indentation your code is difficult to read. Try wrapping it in <c></c> tags and format it to be readable by those unfamiliar with it. From a quick glance there are many errors (such as putting a \n after the semi-colon. Using warnings will catch that.)

That being said, try (actually, don't try it -- just get inspiration from it :P)

#!/usr/bin/perl use warnings; use strict; my @final; # Joined lines will be in here open(URLS, '<', 'urls.txt') or die $!; # I can never remember if < is +read chomp(my @urls = <URLS>); # Every line of URLS is a different element +in @urls close URLS; open(CODES, '<', 'data.txt') or die $!; chomp(my @codes = <CODES>); close CODES; foreach my $url (@urls) { # For every element (line) in @urls, foreach my $code (@codes) { # and for every element in @codes, push @final, $url$code; # append the two and push it into @fin +al } }

The first three lines should be in all your Perl programs. Using warnings will catch a lot of stupid mistakes you will make and using strictures will keep you from making a lot of stupid mistakes. I think the rest of the code is self explanatory.

Updated with more comments.

Update 2: Ikegami reminded me (thanks ikegami :D) that you must chomp() each element of the arrays before you push it into @final to remove the newline at the end. I'll update my code to show this soon. Done (with inspiration from kyle :P).

And you didn't even know bears could type.

Replies are listed 'Best First'.
Re^2: Joining Arrays?
by ikegami (Patriarch) on Dec 20, 2008 at 21:49 UTC

    can never remember if < is read

    It's just like the shell. It's an arrow that indicates flow.

    open(URLS, '<', 'urls.txt') | | | | +----<-------+ from the file into the handle

      :O

      That is my face right now after being bewildered by your explanation :P

      -.- is my face right after that because I did not make the connection at first.

      And you didn't even know bears could type.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://731812]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others examining the Monastery: (7)
As of 2024-04-23 19:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found