Hi,

Actually the worst "constructor" I've seen so far came from someone who considered himself an expert and it was like this:

sub new{
    my $self = shift;
    my $dbh = shift;
    $self->{dbh} = $dbh;
    return $self;
}
[download]

On top of that also calls like the following from the caller:

$sDB->{dbh}->disconnect;
[download]

And it was not in one module, it was in the whole layer that deals with the DB from a web application running under mod_perl! You can imagine for yourself what sort of strange creatures were also lurking around...

Regards,