OR sequence

batmanor has asked for the wisdom of the Perl Monks concerning the following question:

Replies are listed 'Best First'.
Re: OR sequence by chargrill (Parson) on Mar 21, 2008 at 22:18 UTC
You can't do that. You'll need something like: `for my $item( @FORM{ qw/Comments addr name/ } ){ if( $item =~ m/http\|html\|A HREF/i) { &html_message; } }` [download] Other notes: you don't need the HTML and html with the `/i` at the end of your regex Your test for HTML is a little naive. Your test was just testing: `if( there's anything in Comments or there's anything in addr or name matches regex ){ &html_message; }` [download] --chargrill `s*lil; $=join'',sort split q; s;.;grr; &&s+(.(.)).+$2$1+; $; = qq-$_-;s,.,ahc,;$,.=chop for split q,,,reverse;print for($,,$;,$,$/)` [download]	[reply] [d/l] [select]
Re^2: OR sequence by hipowls (Curate) on Mar 21, 2008 at 22:32 UTC
This will call `&html_massage` multiple times if more than one of the three items match. That may not be the OP's intent. To call `&html_massage` only once modify the loop to `ITEM: for my $item( @FORM{ qw/Comments addr name/ } ){ if( $item =~ m/http\|html\|A HREF/i) { &html_message; last ITEM; } }` [download]	[reply] [d/l]
Re^2: OR sequence by ikegami (Patriarch) on Mar 21, 2008 at 22:39 UTC
You need a `last` in your `if` to avoid calling `html_message` three times.	[reply] [d/l] [select]
Re: OR sequence by ikegami (Patriarch) on Mar 21, 2008 at 22:38 UTC
`\|\|` does not form a list of operands to pass to another operator. There's isn't such an operator in Perl5 (but I bet there is in Perl6). Of its two operands, it returns the first one that is true. What you want is `if ( $FORM{'Comments'} =~ m/http\|html\|a href/i \|\| $FORM{'addr'} =~ m/http\|html\|a href/i \|\| $FORM{'name'} =~ m/http\|html\|a href/i )` [download] You can remove the redundancy with a loop `for (@FORM{qw( Comments addr name )}) { if (m/http\|html\|a href/i) { html_message(); last; } )` [download] Is there a reason you didn't apply my suggestion to change `/http\|html\|HTML\|A HREF\|a href/i` to the simpler and equivalent `/http\|html\|a href/i` That's what the "i" does.	[reply] [d/l] [select]
Re: OR sequence (ARRAY ~~ /PATTERN/) by lodin (Hermit) on Mar 21, 2008 at 22:58 UTC
One way of doing it is `if (grep { /http\|html\|a href/i } $FORM{'Comments'}, $FORM{'addr'}, $FO +RM{'name'}) { ... }` [download] In Perl 5.10 that can be written as `if ([ $FORM{'Comments'}, $FORM{'addr'}, $FORM{'name'} ] ~~ /http\|html\| +a href/i) { ... }` [download] which is pretty close to how you tried to write it. The latter is also slightly more efficient for large lists, as it stop to look in the list as soon as it finds a match, in contrast to `grep` which searches the whole list. lodin	[reply] [d/l] [select]
Re: OR sequence by NetWallah (Canon) on Mar 21, 2008 at 23:10 UTC
As usual, TMTOWTDI. Here is (another)one: `if (grep /http\|html\|a href/i,@FORM{qw[name addr Comments]}){ html_message(); }` [download] More alternatives: use the first function from List::Util instead of grep (more efficient for large lists) use the any function from Quantum::Superpositions (the perl6 way)(See the "Query processing" section.) Marginally easier, using List::Util::Superpositions "As you get older three things happen. The first is your memory goes, and I can't remember the other two... " - Sir Norman Wisdom	[reply] [d/l]
Re: OR sequence by apl (Monsignor) on Mar 22, 2008 at 15:13 UTC
You shouldn't have deleted your original question. It prevents others from learning from your question, and confuses those of us who are new to thread.	[reply]
Re^2: OR sequence by Arunbear (Prior) on Mar 22, 2008 at 16:58 UTC
The question has been restored.	[reply]


Clear questions and runnable code get the best and fastest answer
	PerlMonks