Update: another indication that this code has never really been in use is that if the idea is to modify the argument list prior to calling the wrapped do_httpx4, it would have to be called as &do_httpx4 to actually make @_ visible to that subroutine...
Yes, I noticed that initially, then somehow it slipped my mind before I posted.
I'm getting more and more convinced that much of Net::SSLeay is the software equivalent of introns.
Here's another
sub do_httpx4 {
my ($page, $response, $headers, $server_cert) = &do_httpx3;
X509_free($server_cert) if defined $server_cert;
my %hr = ();
for my $hh (split /\s?\n/, $headers) {
my ($h,$v)=/^(\S+)\:\s*(.*)$/;
push @{$hr{uc($h)}}, $v;
}
return ($page, $response, \%hr);
}
If you notice the variable $hh is not used and the m// operator is acting on whatever happens to be in $_.
Am I really looking at the current version of the module (version 1.32 on CPAN)?
|