Beefy Boxes and Bandwidth Generously Provided by pair Networks
Do you know where your variables are?
 
PerlMonks  

Re: What makes a comment "obnoxious"?

by pemungkah (Priest)
on Sep 08, 2007 at 21:53 UTC ( [id://637873]=note: print w/replies, xml ) Need Help??


in reply to What makes a comment "obnoxious"?

I really should upload Test::Perl::Critic::Advisory to CPAN. It wraps all of the Perl::Critic tests in TODOs, so you still see the "failures" (and can fix them), but they don't cause the test suite to fail. And of course you can select your own priorities of what's a real problem and what isn't.

This also probably comes under "tests the author should run but the installer shouldn't have to".

However, back to the thread at hand. Perl::Critic can be valuable as a source of "hey, I should be sure I really wanted to do that" or "oops, we left a non-lexical filehandle in that code" information. I agree that blindly following every piece of its advice is no better than any other form of cargo-cult programming. But discarding the module because people are applying it wrong is, I think, overdoing it.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://637873]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others examining the Monastery: (4)
As of 2024-04-25 10:10 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found