Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine
 
PerlMonks  

Re^2: Build Table with 'n' rows and 'm' columns

by ikegami (Patriarch)
on Nov 02, 2006 at 09:33 UTC ( [id://581859]=note: print w/replies, xml ) Need Help??


in reply to Re: Build Table with 'n' rows and 'm' columns
in thread Build Table with 'n' rows and 'm' columns

There room for a some small improvements.
  • You don't check the result of $dbh->prepare.
  • You don't check the result of $dbh->fetchrow_array.
  • Your loop can be replaced with $sth->fetchall_arrayref.
  • You can also condense the code further using $dbh->selectall_arrayref.
use strict; use warnings; use DBI (); use HTML::TableTiler (); my $dbh = DBI->connect("DBI:mysql:project") or die "Can't connect to Oracle database: $DBI::errstr\n"; my $matrix = $dbh->selectall_arrayref("SELECT * FROM modules"); die "Unable to fetch query results: $DBI::errstr\n" if $dbh->err; my $tt = HTML::TableTiler->new(); print $tt->tile_table($matrix);

Update: I was obviously tired! Fixed the problems identified in replies.

Replies are listed 'Best First'.
Re^3: Build Table with 'n' rows and 'm' columns
by mreece (Friar) on Nov 02, 2006 at 15:07 UTC
    there is still room for some small improvement!
    Global symbol "$sth" requires explicit package name
    ;-)
      And more. Personally, I prefer using SELECT over SELET ;-)

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://581859]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (2)
As of 2024-04-19 19:34 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found