|laziness, impatience, and hubris|
Re: file read timeoutby cdarke (Prior)
|on Aug 07, 2006 at 15:27 UTC||Need Help??|
You seem to be missing at least two close curly brackets, one after the while loop and one after the if statement before the alarm.
You return undef on error, so the final statement might be better written as:
print "Collected $file (rc=". (defined $rc?$rc:'undef') . ")\n";
You are mixing stdout (bare print) and stderr (die) messages. I suggest you only print error messages to stderr, use print STDERR, or warn, or incorporate into the die statement that follows.
Your while loop could be simplified in a number of ways. For example:
Assuming I put the close braces in the right place.
Another approach might be to avoid the loop altogether by testing the file size before you start reading: