Re: Slurp a file

Oops. You've just left $/ set to undef for the rest of the program. This can lead to all sorts of nastiness.

Better to do something like this:

my $file_text;

{
  local $/;
  $file_text = <FILE>;
}

print $file_text;
[download]

Which returns $/ to its original value once you leave the bare block.

Update: I should point out that my correction was to the original version of this node. It's now been changed to use my suggestion.

--
<http://www.dave.org.uk>

"Perl makes the fun jobs fun
and the boring jobs bearable" - me

Comment on Re: Slurp a file Download Code

Replies are listed 'Best First'.
Re: Re: Slurp a file by merlyn (Sage) on Jan 08, 2001 at 21:55 UTC
And my most-frequently-used variant of that is: `my $content = do {local $/; <SOMEHANDLE> };` [download] Short, and effective. -- Randal L. Schwartz, Perl hacker	[reply] [d/l]
Re: Re: Re: Slurp a file by jeroenes (Priest) on Jan 08, 2001 at 21:59 UTC
Tilly pointed me to the use of join in this case. Methinks it's pretty easy: `$content = join '', <SOMEHANDLE>;` [download] Chipmunk, just 4u: One might see the actual response of tilly in this node <grin>. Jeroen I was dreaming of guitarnotes that would irritate an executive kind of guy (FZ)	[reply] [d/l]
Re (tilly) 4: Slurp a file by tilly (Archbishop) on Jan 08, 2001 at 22:52 UTC
That will be slower though. The reason I suggested it is in case someone wanted to use your SuperSplit with tied filehandles. I would not depend on a tied filehandle correctly paying attention to $/, so the join makes sense. But if you care about performance or have good reason to believe that people won't use tied filehandles, then avoid join.	[reply]
(tye)Re3: Slurp a file by tye (Sage) on Jan 08, 2001 at 22:55 UTC
Re: (tye)Re3: Slurp a file by jeroenes (Priest) on Jan 08, 2001 at 23:04 UTC
Re: Re: Re: Re: Slurp a file by merlyn (Sage) on Jan 08, 2001 at 22:03 UTC
That's more expensive, though. Benchmarks are probably being whipped up even as I type this. {grin} -- Randal L. Schwartz, Perl hacker	[reply]
Re: Re: Re: Re: Re: Slurp a file by davorg (Chancellor) on Jan 08, 2001 at 22:07 UTC
(tye)Re2: Slurp a file by tye (Sage) on Jan 08, 2001 at 22:13 UTC
Some notes below your chosen depth have not been shown here


Don't ask to ask, just ask
	PerlMonks