Re^3: returns not working

in reply to Re^2: returns not working
in thread returns not working

i think i started doing this out of some vague uneasiness about return handling scalars or lists. now that i think about it, it's pretty much a personal style thing at this point. which do you think is more appropriate?

Comment on Re^3: returns not working

Replies are listed 'Best First'.
Re^4: returns not working by davido (Cardinal) on Aug 24, 2005 at 16:02 UTC
From perlsytle: Along the same lines, just because you CAN omit parentheses in many places doesn't mean that you ought to: `return print reverse sort num values %array; return print(reverse(sort num (values(%array))));` [download] When in doubt, parenthesize. At the very least it will let some poor schmuck bounce on the % key in vi. Even if you aren't in doubt, consider the mental welfare of the person who has to maintain the code after you, and who will probably put parentheses in the wrong place. My rule of thumb is that if the syntax and meaning are perfectly clear without parenthesis, you can omit them. If leaving them out makes the code confusing, alters the outcome, or impedes readability, better include them. Dave	[reply] [d/l]

Replies are listed 'Best First'.

Re^4: returns not working
by davido (Cardinal) on Aug 24, 2005 at 16:02 UTC

From perlsytle:

Along the same lines, just because you CAN omit parentheses in many places doesn't mean that you ought to:

return print reverse sort num values %array; return print(reverse(sort num (values(%array))));
[download]

When in doubt, parenthesize. At the very least it will let some poor schmuck bounce on the % key in vi.

Even if you aren't in doubt, consider the mental welfare of the person who has to maintain the code after you, and who will probably put parentheses in the wrong place.

My rule of thumb is that if the syntax and meaning are perfectly clear without parenthesis, you can omit them. If leaving them out makes the code confusing, alters the outcome, or impedes readability, better include them.

Dave

[reply]
[d/l]

In Section Seekers of Perl Wisdom