• You call the new() sub without passing it any parameters, and inside the sub you attempt to read from $self, which is an empty hashref.
• You pass the subject and message params to send as a hashref, yet they end up in the $user variable, which itself is never used

Also, you have a global %mail hash, which will stay the same for every PL::Mail object you create, which probably isnt what you want.. To make it unique per object, you need to store that data in $self.

Also you need to be very careful about case sensitivity, $self->{SUBJECT} and $self->{subject} are not the same thing.

Here is an attempt at repair:

package PL::Mail;
use strict;
use Mail::Sendmail;

## Only global is your server since it doesnt change (?)
my $server = 'pop.dnvr.qwest.net';

## The new constructor just sets up the server and the From address si
+nce these are static (could put the server name here directly and not
+ have a global variable)
sub new {
        my $class = shift;
        my $self  = {};
        $self->{mail}{Smtp}    = $server;
        $self->{mail}{From}    = 'Postmaster <noreply@dhoss.cjb.net>';
        bless $self, $class;
        return $self;
}


## The send method is passed a hashref, containing subject, message an
+d optionally a to key.
## eg $obj->send({subject => 'testing', message => 'just trying to sen
+d mail', to => 'me'});

## The $self hashref, which represents the object, is used to store al
+l the parts of the %mail hash, which is then passed to sendmail
sub send {
    my ($self, $data) = @_;
    
    $self->{mail}{To}   = $data->{to}   ? $self->{to}   : 'Devin Austi
+n <devin.austin@gmail.com>';
    $self->{mail}{Subject} = $data->{subject};
    $self->{mail}{Message} = $data->{message};
    my $date = Mail::Sendmail::time_to_date();
    $self->{mail}{Message} .= <<""
    
    Message sent on $date
    From $ENV{REMOTE_ADDR}
    All information contained in this message do not reflect the 
    ideas of Devin Austin or MorningStarWeb and it's affiliates.
    

    ;
    
    if (sendmail %{$self->{mail}) {
        print STDERR $Mail::Sendmail::error;
    } else {
        print STDERR "Error sending mail ($date): $!";
    }
}
[download]

C.

There are a few problems here. Mostly they seem to be to do with your understanding of what $self actually is. $self is generally a hashref, which contains your instance variables, like 'To' and 'Smtp'.

At the moment, your new method blesses an empty hashref containing no data. $self should probably contain the data you currently assign to %mail. Something like...

package PL::Mail;
my $server = 'pop.dnvr.qwest.net';
sub new
{
    my ( $class, $to ) = @_;
    my $self  =
    {
        Smtp => $server,
        From => 'Postmaster',
        To   => $to ? $to : 'devin.austin@gmail.com',
    }; # hashref containing instance variables
    return bless $self, $class;
}
[download]

There are similar problems in your send method. You are also calling the send method incorrectly. You want something like...

my $obj = PL::Mail->new( $recipient );
$obj->send( subject => 'blah', comments => 'ftui' ):
[download]

Note that because you are passing these parameters to send as a list, the way you handle send's arguments needs to be something like...

my( $self, %params) = @_;
$self->{ subject } = $params{ subject };
...
[download]

Don't be too disheartened: at least you're using  strict :) I think you could do with having a look at perltoot. Also, Mail::Sendmail is so simple, I'm not sure if you really need to be writing a wrapper for it...

It is very simple....and I had thought of trashing my wrapper until I got it to work...
meh.

I haven't run the code but it looks to me like your Mail class is looking for "SUBJECT" and "MESSAGE" and you are calling it with "subject" and "message"?

Any-way why aren't you using one of the good mail modules from CPAN? :-)

Case shouldn't matter with named parameters...at least afaik...
Well MIME::Lite was having problems on my system...but i'm going to try Mail::Sender out, does that count? :-D
meh.

In that case you might find flexible command line mail sender (SMTP) insightful.


holli, /regexed monk/

Case shouldn't matter with named parameters...at least afaik...

I don't think that is correct, at least that is not what I am seeing :)

FWIW I use Tilly's code to check named parameters.

--
Murray Barton
Do not seek to follow in the footsteps of the wise. Seek what they sought. -Basho

PL::Mail->new();
[download]