http://qs321.pair.com?node_id=455607


in reply to Re: Updating or Inserting a database from a txt file
in thread Updating or Inserting a database from a txt file

Actually the OP's previous posts seem different from this one. Previously he was looking for answers and now he's looking for improvements.

Have I missed something?

Nik, please be polite. Rudeness will only make things worse.

Hope you find your answers.

Regards,
  • Comment on Re^2: Updating or Inserting a database from a txt file

Replies are listed 'Best First'.
Re^3: Updating or Inserting a database from a txt file
by Nik (Initiate) on May 10, 2005 at 18:17 UTC
    Sorry man, i got carried away there but i become mad with the both of them and especially Animator on irc.
    Yes iam trying to improve the script as you correctly noticed.

    I changed it again. Here it is now:
    my (@row, $gamename, $gamedesc, $gamecount); my $select = $dbh->prepare( "SELECT * FROM games WHERE gamename=$gamen +ame" ); my $insert = $dbh->prepare( "INSERT INTO games (gamename, gamedesc, ga +mecounter) VALUES (?, ?, ?)" ); my $update = $dbh->prepare( "UPDATE games SET gamedesc=?, gamecount=?+ +1 where gamename=?" ); open (FILE, "<../data/games/descriptions.txt") or die $!; while (<FILE>) { chomp; ($gamename, $gamedesc) = split /\t/; $select->execute( $gamename ); if ($select->rows) { $update->execute( $gamedesc, $gamecount, $gamename ); } else { $insert->execute( $gamename, $gamedesc, 0 ); } } close (FILE);
    the descriptions.txt contains a blank line after each line of info. I dont want it to be loaded and also every time games.pl is runnign it gets doubled and doubles each time!

    Anyone can see why?