There are a couple of things you should be aware of in this code. First, you try to print out all the values each time you have read a line from the file. This will of course generate warnings about the use of uninitialized values.

Second, you should probabely use a datastructure to hold your data. As it stands now, you will only get the last record of data, and it will not be correct. It will probabely contain data from earlier records.

A reasonable datastructure to use in this case might possibly be to use a hash of hashes

%data = (user1 => { "User-Service" => "Framed-User",
                    "Framed-Protocoll" => "PPP",
                    # etc...
                  },
         user2 => { ... }
        );
[download]