sub Got_Command ($$) {
# bad routine name. Sounds like it should return a boolean.
# icky prototypes! Should be:
# sub Got_Command {
my $Command = $1; # EXEC Command - defined earlier
my $Request_id = $2;
# bad variable names--should be lowercase
# bad parameter passing--do you mean
# my ($command, $request_id) = @_[0,1]; ?
# Pass parameters to a stored procedure
print "$Command\n";
my $sthB_A = $dbh->prepare("$Command") or
die "Couldn't prepare query: ".$dbh->errstr;
# useless use of quotes--prepare($command)
$sthB_A->execute() or
die "Couldn't execute query: ".$sthB_A->errstr;
##########################################
# Return Results here #
##########################################
# lame comment style--hard on the eyes
# also it appears you need to "use strict"
$Return_results = "Select * from Result_storage_keep where Unique_id
+entifier = '".$Request_id."'\;";
# should enumerate select columns and use
# SQL statement placeholders, i.e.
# my $return_results = "Select col1, col2 from
# Result_storage_keep where Unique_id=?";
my $get_results_B = $dbh->prepare("$Return_results") or die "Couldn
+'t prepare query: ".$dbh->errstr;
# more useless use of quotes, prepare($results)
$get_results_B->execute() or
die "Couldn't execute query: ".$get_results_B->errstr;
while (my @row = $get_results_B->fetchrow_array ) {
}
foreach (@row){
print OUTPUT_FILE "$item0\n";
# where does $item0 come from?
}
}
|