Swapping keys and values in a hash with slices

pernod has asked for the wisdom of the Perl Monks concerning the following question:

From perlfunc on the values function:

The values are returned in an apparently random order. The actual random order is subject to change in future versions of perl, but it is guaranteed to be the same order as either the keys or each function would produce on the same (unmodified) hash.

I think this means that I can (safely) do the following to build a new hash where the key/value pairs have switched roles (ie. for each pair, the new hash uses the value as key, and the key as value):

use Data::Dump qw( dump );

my %hash = ( 1 => "Piker", 2 => "Vin", 3 => "Sang" );
my %revhash;
@revhash{ values %hash } = keys %hash;

print dump( \%hash ), "\n";
print dump( \%revhash ), "\n";
[download]

Have I missed something regarding the hash iterators, or is this an acceptable way of doing things? I am well aware of other solutions to this problem using loops and map, but I'm curious and trying to learn something on slices.

pernod
--
Mischief. Mayhem. Soap.

Comment on Swapping keys and values in a hash with slices Select or Download Code

Replies are listed 'Best First'.
Re: Swapping keys and values in a hash with slices by tomhukins (Curate) on Oct 20, 2004 at 10:31 UTC
This seems reasonable enough to me, with the usual caveat that you will lose information if multiple elements share the same value. I would never use this code in production, though. You mention other solutions using loops and map, but I find the `%revhash = reverse %hash` idiom more elegant.	[reply] [d/l]
Re: Swapping keys and values in a hash with slices by ihb (Deacon) on Oct 20, 2004 at 10:39 UTC
It is an acceptable way and typically `$large{keys %foo} = $values %foo;` [download] is used when you want to add one hash to another (large) hash, avoiding to do `%large = (%large, %other)` [download] which does unnecessary copying. As tomhukins pointed out, there are easier ways of doing what you're doing. `ihb` See perltoc if you don't know which perldoc to read! Read argumentation in its context!	[reply] [d/l] [select]
Re: Swapping keys and values in a hash with slices by pg (Canon) on Oct 20, 2004 at 10:27 UTC
But nobody promised you that keys and values would return in the same order though ;-) `use Data::Dump qw( dump ); my %hash = ( 1 => "Piker", 2 => "Vin", 3 => "Sang" ); my %revhash; $revhash{$hash{$_}} = $_ for (keys(%hash)); print dump( \%hash ), "\n"; print dump( \%revhash ), "\n";` [download] Update: Forget about this, just use reverse as tomhukins said below.	[reply] [d/l]
Re^2: Swapping keys and values in a hash with slices by revdiablo (Prior) on Oct 20, 2004 at 17:57 UTC
nobody promised you that keys and values would return in the same order Yes, they did. Read the quoted docs more carefully: The values are returned in an apparently random order. The actual random order is subject to change in future versions of perl, but it is guaranteed to be the same order as either the keys or each function would produce on the same (unmodified) hash.	[reply]


No such thing as a small change
	PerlMonks